lwitzani / homebridgeStatusWidget

MIT License
371 stars 143 forks source link

Custom homebridge title #25

Closed m-rossi closed 3 years ago

m-rossi commented 3 years ago

First of all: Thanks for this nice and useful widget!

I added a configuration value for a custom homebridge instance title. This is useful if you run multiple homebridge instances or devices. I use, for example, an extra Raspberry Pi with camera module as a separate homebridge instance.

Do I need to increase the CONFIGURATION_JSON_VERSION in https://github.com/lwitzani/homebridgeStatusWidget/blob/main/homebridgeStatusWidget.js#L11 ?

lwitzani commented 3 years ago

Theoretically yes. If you change the configuration, you should increase the counter. This leads to older configurations being deleted which is actually not that nice. That‘s why i did not change it yet since there could be some kind if migration logic that i did not implement yet.

Did you see the variable systemGuiName ? This is actually the place where you define which system it is...!(?)

m-rossi commented 3 years ago

Yes I saw that, however it is not used anywhere else...ordo you propose to use that variable for a custom title?

lwitzani commented 3 years ago

What do you mean with „it is not used anywhere else“? The text you use here is shown in the bottom right at the Uptimes section. And this variable is meant to express which system this widget is all about. I have two homebridges on two Raspberry Pis running and i use this variable to differentiate the widgets/to know which one is which

m-rossi commented 3 years ago

Ooops, somehow my search did not find that, I updated my comment.

lwitzani commented 3 years ago

So can i close this pull request? In the latest code i put the title into a variable and put this variable to the possible configuration candidates. I‘ll add them (maybe) with migration logic in the future. But i dont think we need the changes you made (sorry?)

m-rossi commented 3 years ago

Yes, please add this variable in the future!