lwj1711 / pe

0 stars 0 forks source link

Nonsensical emails allowed #11

Open lwj1711 opened 2 years ago

lwj1711 commented 2 years ago

Email regex should check if the email is proper. This might cause problems due to typos too, which is fairly common.

image.png

nus-pe-bot commented 2 years ago

Team's Response

Your email is valid under the RFC5322 international standard for email validation.

image.png

Click here to see more

image.png

Our email validation follows closely to the RFC5322 standard and is even more restrictive on the special characters to allow for only valid and professional emails.

Since the email you claim is invalid is actually valid under the RFC5322 standard, we will be rejecting this issue.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I have taken a look at this 'RFC 5532' thing, and it looks extremely dubious and outdated (last updated 2008, it's been 13 years).

It seems pointless to follow this standard, since it doesn't seem to help the app check for proper emails at all (accepting an email like alex_yeoh@gma213213il.co213123m).

Apart from my suspicions on this RFC 5532 standard, the product is also targeted at Singapore employers, and throughout my entire life in this country I have never seen an email outside those that follow a conventional standard that we are all familiar with.

It feels like the group had failed to properly do a validation check for email entries and is trying to smoke their way out of it.


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Group has failed to mention why the severity was reduced at all.

The lack of a validation check is clearly not a severity Low issue, since it does not result in problems that just 'appear only in very rare situations and cause minor inconvenience'.

I believe issue should be at least given a severity of Medium, since it causes occasional inconvenience, especially since typos are not uncommon, and data entries should be properly checked.