lwj1711 / pe

0 stars 0 forks source link

Dangerous clear command #12

Open lwj1711 opened 3 years ago

lwj1711 commented 3 years ago

When it is used it, especially since there's no confirmation, might result in a user's data being wiped out entirely.

image.png

This is especially problematic since the app does not come with an 'undo' command, so it results in permanent deletion of everything.

nus-pe-bot commented 3 years ago

Team's Response

The clear feature correctly works in the expected way as described in UG and the user should know what it does without confirmation message:

image.png

Product is still usable even after using the clear command.

Adding the undo command is non-trivial, thus violating this:

image.png

Additionally, severity is also inappropriate regardless of whether we accept or reject so we have taken the initiative to adjust it accordingly.

image.png

Given that this feature works correctly, and that by working correctly, it does not cause the product to be unusable, we will be rejecting this issue.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I understand that this is the expected behaviour as described in the UG, and that the undo command is extremely non-trivial (which is why I never brought up how the lack of undo command alone is a feature flaw).

However, it is clear that the effects of the clear command can be catastrophic and does not merely happen in 'rare situations and causes minor inconvenience', especially without having an undo command. Users who type in clear, especially if they have large amounts of data will have major problems, especially since there is no way for them to recover from this (no undo command, no way to edit json file at this stage).

It is clear that at this point in time the product becomes literally unusable should all the data be wiped since there is no way to recover from this.

As such I believe the issue warrants a severity High tag.


:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: It is clear that the effects of the clear command can be catastrophic and does not merely happen in 'rare situations and causes minor inconvenience', especially without having an undo command. Users who type in clear, especially if they have large amounts of data will have major problems, especially since there is no way for them to recover from this (no undo command, no way to edit json file at this stage).

It is clear that at this point in time the product becomes literally unusable should all the data be wiped since there is no way to recover from this.

As such I believe the issue warrants a severity High tag.