Open lwj1711 opened 2 years ago
We agree that we should have provided a warning message for nonsensical phone numbers.
However, we also want to allow for international numbers which could take more than just 8 digits since applicants could be foreigners as well.
Given that this sort of nonsensical input should be a typo mistake and can be corrected by our edit feature, it should be a rare occurrence (typo) that is unlikely to affect normal operations of the application.
Hence we will downgrade the severity of this issue to Low
and accept it.
Team chose [severity.Low
]
Originally [severity.Medium
]
Reason for disagreement: Flaw should not be only low.
A typo resulting in an additional digit added to a number (for example, 92313123 to 923123123) can result in huge repercussions. If the number is saved as 923123123, it might just be a typo, but the user then cannot easily tell what the original number should be, since he/she would not know which the additional digit is. As such, it might result in the interviewee being uncontactable through phone completely.
Clearly, the problem cannot easily be corrected by the edit feature as the group has mentioned.
Since this flaw causes rather major inconvenience in such cases to users, it should at least be a severity Medium.
There doesn't seem to be a check for the numbers to be a valid one, and nonsensical strings of numbers can be inputted under the phone number.
Since RecruitIn is an app made for recruiters in Singapore (stated in UG), perhaps the check for phone numbers can be 8 digit numbers starting with 8 or 9.