lwlshawn / pe

0 stars 0 forks source link

Phone number field might be too restrictive #10

Open lwlshawn opened 2 years ago

lwlshawn commented 2 years ago

image.png

The phone number field has a hard cap of 8 digits, disallowing local codes. This prevents the user from keying in any non-singaporean phone numbers. The user guide does not seem to make explicit that the application is meant for use only in Singapore, so perhaps this can be outlined in the documentation, or otherwise made more lenient.

nus-pe-bot commented 2 years ago

Team's Response

This has already been specified in the User Guide under "Structure of an elderly contact". Please take a look

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Here is the section of the UG they are referring to:

image.png

They have not addressed the issue I raised; being that even if they have documented their decision, I think their decision is inappropriate given that this prevents a user from keying non-singaporean numbers into the application. In this day and age when message applications like whatsapp and telegram are ubiquitous, I think it is very possible for there to be people in Singapore who get by, with a non-singaporean number.

This is made worse by the fact that their user guide does not even explicitly outline the target audience as singaporean. It simply says "facilitate community worker's visits to the elderly", as seen here:

image.png

I would thus argue that this qualifies as the application being insufficiently optimised for target users, general community workers, since phone numbers in other countries can certainly have more then 8 digits. This is a valid reason outlined in the textbook here:

image.png