lwlshawn / pe

0 stars 0 forks source link

Inconsistent warnings with lastdate and futuredate errors #6

Open lwlshawn opened 3 years ago

lwlshawn commented 3 years ago

image.png

When a last visit date is in the future, the user gets a warning but there is no other indication on the application box. However, when a future visit is in the past, the date is highlighted in red, and the contact box for the user is in red as well.

nus-pe-bot commented 2 years ago

Team's Response

We chose to highlight the date only if next visit is overdue because it is the most urgent thing the user would need to attend to. The warning in the box was done only to inform the user of a possible error, and is not urgent to attend to, which is why we did not highlight it in the personcard.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The summary of the issue, is that the date for the "last visit", should be in the past and not the future, and the date for the "next visit", should be in the future, not in the past. These are both reasonable requirements, however, the two types of errors are not treated the same way in the application.

When a date for the "last visit" is in the future, the user gets a warning, but when a date for the "next visit" is in the past, the box is highlighted in red.

They are providing an explanation here that they think a "next visit" error is more serious, but this is not outlined anywhere in the User Guide to explain to a user why there is a difference between the two warnings. Thus, I believe that this is still a cosmetic bug, that may be of concern to a small number of users who might wonder why the style of warnings for the two types of errors are different.

If it had been explained in the User Guide to allay the concerns of potential users, then I don't think this is a bug, but given the lack of explanations, I still think this qualifies as a cosmetic issue in their application.