lwolf / kube-cleanup-operator

Kubernetes Operator to automatically delete completed Jobs and their Pods
MIT License
498 stars 109 forks source link

Add build stage to the Dockerfile #49

Closed artem-zinnatullin closed 4 years ago

artem-zinnatullin commented 4 years ago

This allows proper development and Docker build on macOS or Windows as well as version-controlled development environment, Go binaries are target platform specific.

I didn't update Travis release pipeline, personally I'd use this multi-stage Docker build as a Travis build but it's up to you 🙃

Docs: https://docs.docker.com/develop/develop-images/multistage-build/

lwolf commented 4 years ago

Yeah, makes sense. I haven't touch this for years. Thanks