search

lwolf / kube-cleanup-operator

Kubernetes Operator to automatically delete completed Jobs and their Pods
MIT License
503 stars 109 forks source link

Fix Typos #52

Closed ashuparekh closed 4 years ago

ashuparekh commented 4 years ago

~~A recent PR #50 changed the behavior where cronjob jobs and pods will not be deleted, which altered the previous default However, there may be use-cases to act on them too before cronjob actually clears them on their own. Adding an option which can be set to delete the cronjob related stuff too, which was the default way beforehand.~~

Some typos fixed.

ashuparekh commented 4 years ago

@lwolf @sergeylanzman Please have a look, Thank you!

lwolf commented 4 years ago

Thanks @ashuparekh . I'm aware that it breaks current defaults, that's why I didn't make a release with it. I'm going to hold on merging this PR, since I'm doing a refactoring in the codebase. but the change in behavior will be opt-in.

lwolf commented 4 years ago

If you want, you can update the PR to only include fixes to typos, I can merge it right away.

ashuparekh commented 4 years ago

Thank you @lwolf , that sounds good! Have modified the PR to only fix the typos.