lwolf / kube-cleanup-operator

Kubernetes Operator to automatically delete completed Jobs and their Pods
MIT License
498 stars 109 forks source link

added helm chart #66

Closed haarchri closed 3 years ago

haarchri commented 3 years ago

feature request completed for #60 please have a look ;)

haarchri commented 3 years ago

It looks like you generated this chart using old helm2 which is in process of being retired

it is running with helm3 version.BuildInfo{Version:"v3.4.2"

what is in your opinion not v3 ?

lwolf commented 3 years ago

At least the value of apiVersion: v1 signaling that it was generated for helm2. Also, helm3 change the way how image.tag is populated, it now uses appVersion field for the tag, which allows one to not set tag to latest

Here is the output from helm2 vs helm3 of the Chart.yaml file:

$ helm3 create deploy/helm/test3
$ cat deploy/helm/test3/Chart.yaml

apiVersion: v2
name: test3
description: A Helm chart for Kubernetes

# A chart can be either an 'application' or a 'library' chart.
#
# Application charts are a collection of templates that can be packaged into versioned archives
# to be deployed.
#
# Library charts provide useful utilities or functions for the chart developer. They're included as
# a dependency of application charts to inject those utilities and functions into the rendering
# pipeline. Library charts do not define any templates and therefore cannot be deployed.
type: application

# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
appVersion: 1.16.0

vs

$ helm create deploy/helm/test
$ cat deploy/helm/test/Chart.yaml

apiVersion: v1
appVersion: "1.0"
description: A Helm chart for Kubernetes
name: test
version: 0.1.0
haarchri commented 3 years ago

adopted Charts.yaml for helmv3 - in deployment the field was present ;)

any other change requests ?