search

lwolf / kube-cleanup-operator

Kubernetes Operator to automatically delete completed Jobs and their Pods
MIT License
498 stars 109 forks source link

Remove restartCount check #9

Closed aalubin closed 6 years ago

aalubin commented 6 years ago

Hi, Currently pods with restart count > 0 will not be handled.

I have few issues with this check:

  1. It is only for the first container in the pod, but this can be easily checked.
  2. I am not sure restart count is relevant, now that you can keep success/failed pods/jobs
  3. As is, it causes index out of range when a new job is added and container was not started yet.

So I suggest to remove this check.

lwolf commented 6 years ago

I agree, with the new keep success/failed we can get rid of this check.

aalubin commented 6 years ago

OK I will PR both this and an updated maven file later on today

lwolf commented 6 years ago

awesome, thanks.

I believe you meant makefile, not maven :)

aalubin commented 6 years ago

Yeap Doing some maven changes@work in parallel :)

aalubin commented 6 years ago

10

aalubin commented 6 years ago

@lwolf you can now run docker-release if you have quay.io permission. further work needs to be done to the travis file so it will push automatically with every commit

lwolf commented 6 years ago

@aalubin I have just released it manually to both docker and quay.io. works great.