search

lwolf / kube-cleanup-operator

Kubernetes Operator to automatically delete completed Jobs and their Pods
MIT License
498 stars 109 forks source link

Multi-arch images with Github Actions #95

Closed awilmore closed 3 months ago

awilmore commented 3 months ago

Hi @lwolf,

I've created two Github actions that should do the job of replacing Travis:

Caveat - this is my first time using GoReleaser. I tested this using my dockerhub login and it seems to work okay: https://hub.docker.com/r/awilmore/kube-cleanup-operator/tags

The github action requires that you set the values for QUAY_USERNAME and QUAY_PASSWORD as action secrets here: https://github.com/lwolf/kube-cleanup-operator/settings/secrets/actions

That's about it. I hope this is enough info to get this set up as your Travis replacement.

UPDATE

This PR addresses:

lwolf commented 3 months ago

thanks. looks good. let's try it...

lwolf commented 3 months ago

it did work, but there are a couple of things:

  1. the resulting image was tagges as quay.io/lwolf/kube-cleanup-operator:0.8.4 (should be v0.8.4). I'll update .goreleaser to prependv` before the {{version}}

The other thing is that goreleased haven't added the images to the release description (but to be honest I don't remember if it ever did that or I was adding it manually all the time).

Anyway thanks again!

awilmore commented 3 months ago

Thanks @lwolf 🙏