search

lwolf / kube-cleanup-operator

Kubernetes Operator to automatically delete completed Jobs and their Pods
MIT License
498 stars 109 forks source link

Use Tag instead of Version in goreleaser config #97

Open awilmore opened 3 months ago

awilmore commented 3 months ago

Hi @lwolf , this is just a small change, but we are hoping the next image, v0.8.5, will be created as a cross-platform image (the current v0.8.4 image seems to be x86 only).

lwolf commented 3 months ago

Can you explain how this change supposed to fix the issue?

awilmore commented 3 months ago

Can you explain how this change supposed to fix the issue?

There is no issue with the goreleaser config as it is. This PR just switches to using {{ .Tag }} instead of v{{ .Version }}.

The actual issue is that when the v0.8.4 tag was created, a cross-compiled 0.8.4 image was released by the Github action. But somehow a v0.8.4 image was also released, which is actually just a retagged version of the 0.8.4-amd64 image:

image

So this PR is a very minor change, and it is more about the next release, v0.8.5, which should hopefully show up in quay.io as a normal manifest wrapping the amd64 and arm64 images.

lwolf commented 3 months ago

I manually retagged 0.8.4 into v0.8.4 before adding this change https://github.com/lwolf/kube-cleanup-operator/commit/538f00d447db507f528fd6f94fa2c3d81b9302f3 I believe next tag should be good anyway.

awilmore commented 3 months ago

@lwolf if this is okay to merge and tag, we will be able to see if the next release is cross-compiled correctly.