search

lwolf / stolon-chart

Kubernetes Helm chart to deploy HA Postgresql cluster based on Stolon
MIT License
105 stars 39 forks source link

Adding kubernetes backend to stolon-chart #20

Closed Flowkap closed 6 years ago

Flowkap commented 6 years ago

Details can be found in issue https://github.com/lwolf/stolon-chart/issues/18

lwolf commented 6 years ago

Just made a diff of the same resource after few seconds. resourceVersion and metadata.annotations.stolon-status are constantly getting change.

lwolf commented 6 years ago

I can confirm that the issue is present is original examples of stolon, so I'm going to create issue about it there.

Flowkap commented 6 years ago

I can confirm the continuous change of the resources as well. I'll later go through all your valid comments and try out if the labeling is fixed (seems to be at least in master)

Flowkap commented 6 years ago

Updated the PR

Flowkap commented 6 years ago

I added the RBAC stuff as well. I left the two open points in regard to the labels open and wait for your response first.

Flowkap commented 6 years ago

Sorry I was sick the last few days.

I see your point about redundant labels on pods, and I'm fine with removing heritage from pods. But I still prefer to have component and chart labels everywhere. This labels are useful for manual selection.

Ok see that as well. Will change it as well as fix the two wrong labels you mentioned above :)

Flowkap commented 6 years ago

Shall we wait for https://github.com/sorintlab/stolon/issues/466 to resolve until merge or change it when it's finished (don't know when this could be part of a next release)

We anyway already use my fork for internal testing as our system is under heavy development still. I would'nt mind.

lwolf commented 6 years ago

Let's release it as is, and update labels if and when that issue is resolved. Thank you for the work on this.