search

lwolf / stolon-chart

Kubernetes Helm chart to deploy HA Postgresql cluster based on Stolon
MIT License
105 stars 39 forks source link

persistence vs persistentVolume variable naming #31

Closed ivankennethwang closed 5 years ago

ivankennethwang commented 5 years ago

In commit 1cd50e446259cded7493004c59261274c1748186, the chart was changed but the values.yaml wasn't.

I believe it should have a change such as:


-    {{- if .Values.persistentVolume.storageClassName }}
-    {{- if (eq "-" .Values.persistentVolume.storageClassName) }}
+    {{- if .Values.persistence.storageClassName }}
+    {{- if (eq "-" .Values.persistence.storageClassName) }}

-        storageClassName: "{{ .Values.persistentVolume.storageClassName }}"
+        storageClassName: "{{ .Values.persistence.storageClassName }}"```
lwolf commented 5 years ago

thanks, I somehow missed that inconsistency