lwouis / alt-tab-macos

Windows alt-tab on macOS
https://alt-tab-macos.netlify.app
GNU General Public License v3.0
10.59k stars 322 forks source link

Pressing , could show the Preferences window #1813

Open LiamKearn opened 2 years ago

LiamKearn commented 2 years ago

Similar to Alfred. You can open Alfred than press , to quickly open preferences.

lwouis commented 2 years ago

Hi @LiamKearn,

This would be nice. It's already bound to command+, actually, but you need to have AltTab active to trigger it. AltTab can be active if you have already the Preferences or the Feedback window open, or if you already have clicked on the menubar icon and its menu is open. It's not super useful that way, that's for sure.

The issue with implementing your suggestion is that AltTab allow its users to rebind shortcuts to practically any keys. This means someone may bind AltTab to command+, which would conflict with this feature. Thus we would need to either reserve this shortcut, or let the user chose between "ok I don't want to that in the end" and "let me do it, and unbind the existing command+, functionality". This is what we already do if you try and bind a shortcut but there is already a shortcut with the same keys bound within AltTab.

Finally, another issue to clarify is what should happen if the user is not using command as a meta key. If they use option or shift for instance. Should option+, or shift+, show the preferences? This is questionable.

So yes a good idea, yes doable, but also some non-trivial amount of work, and unfortunately the benefits are pretty niche I think.

That would be a nice PR for someone who wants to contribute something of reasonable size/complexity.