lws99 / qbb2023-answers

0 stars 0 forks source link

Week 3 Feedback #4

Open dtaylo95 opened 1 year ago

dtaylo95 commented 1 year ago

Python script that performs alignment based on user input

2.75/8

Exercise Points Possible Grade
Read in inputs 2 1.5
Initialize matrices 1 0.5
Populate matrices 2 0.75
Perform traceback 2 0
Write alignment to file 0.5 0
Print out alignment score and number of gaps in each sequence 0.5 0

DNA alignment file

0/0.5

AA alignment file

0/0.5

README.md with alignment score and number of gaps in each sequence for each alignment

0/1

Total: 2.75/10

Great work so far.

Here's what you need to do for full credit:

lws99 commented 1 year ago

I have pushed the updated and corrected assignment! Thank you for the comments!

dtaylo95 commented 1 year ago

Nice work! There are two very minor remaining issues:

  1. Make sure your while loop end condition is correct. We want to end in the top left, but what happens if row or col reaches 0, but the other does not? https://github.com/lws99/qbb2023-answers/blob/5f7763729567b311e2d5ffc930f0f763db69b4ac/week-3/assign_week3.py#L185
  2. No points off, but when you ran the DNA alignment, I think you might have used a -10 gap penalty instead of -300

Current grade: 9.75/10