lwsjs / local-web-server

A lean, modular web server for rapid full-stack development.
MIT License
1.2k stars 85 forks source link

Programmatic API: configFile option is not honored #115

Closed kenrick95 closed 5 years ago

kenrick95 commented 5 years ago

When using the programmatic API of this package, I followed the example and documentation from the wiki.

On that page, it listed the option configFile as a parameter to LocalWebServer.listen()

So, I expect this piece of codes to work as intended (options are read from configFile):

const LocalWebServer = require('local-web-server')
const localWebServer = new LocalWebServer()
const server = localWebServer.listen({
  configFile: './path-to-file/lws.config.js'
})

server.close() 

But unfortunately, the config file is never read. I checked the source code in lws package and indeed, the config is only used at lib/command/serve.js which I believe is only invoked in the CLI application use case.

75lb commented 5 years ago

interesting, thanks for reporting this.. yes, the configFile option should be honoured from both API and CLI use cases. Will look into this soon - thanks for the PR.

75lb commented 5 years ago

Fixed and released in v3.0.0