search

lwsjs / local-web-server

A lean, modular web server for rapid full-stack development.
MIT License
1.22k stars 86 forks source link

404 when query params have periods in them. #122

Closed stormmuller closed 5 years ago

stormmuller commented 5 years ago

I'm getting some strange behavior when I hit a URL with a period in a query value.

Example: https://my-fake-site/login?callback=asfasdf.asdf I get a 404

When I hit just https://my-fake-site/login?callback=asfasdf it's golden...

For context, I'm working with a SPA

Originally I ran: ws --spa index.html Then I thought the URL was being interpreted as a static file due to the period. So I added the --spa.asset-test-fs flag.

Making the final command ws --spa index.html --spa.asset-test-fs Which still doesn't work

75lb commented 5 years ago

interesting.. I'll try and reproduce it in a min..

On Mon, 1 Jul 2019, 13:57 Storm Muller, notifications@github.com wrote:

I'm getting some strange behavior when I hit a URL with a period in a query value.

Example: https://my-fake-site/login?callback=asfasdf.asdf I get a 404

When I hit just https://my-fake-site/login?callback=asfasdf it's golden...

For context, I'm working with a SPA

Originally I ran: ws --spa index.html Then I thought the URL was being interpreted as a static file due to the period. So I added the --spa.asset-test-fs flag.

Making the final command ws --spa index.html --compress -p $PORT --spa.asset-test-fs Which still doesn't work

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/lwsjs/local-web-server/issues/122?email_source=notifications&email_token=AAJQV3HFFZQCKJVNUJG2SKDP5H5LNA5CNFSM4H4SECZ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G4UHUCA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJQV3EH7QYJGWKDDJ76EQ3P5H5LNANCNFSM4H4SECZQ .

75lb commented 5 years ago

i can't reproduce this.. if I launch a server with this command, the /login?callback=asfasdf.asdf path returns 404.

$ ws --spa index.html

But with this command the same path works fine. 

$ ws --spa index.html --spa.asset-test-fs

Are you sure you have the latest local-web-server installed? Just reinstall it just be sure you have the latest of everything, including the dep tree. Which OS and node version are you using?

75lb commented 5 years ago

FYI, you spotted a separate bug

75lb commented 5 years ago

https://github.com/lwsjs/spa/issues/3 is now fixed. If you reinstall, the fullstop in your querystring won't break the default asset-test, meaning you won't need the --spa.asset-test-fs flag.

stormmuller commented 5 years ago

That was really quick! thanks.

75lb commented 5 years ago

no problem, let me know if you find anything else.