Docker update base images

lwthiker / curl-impersonate

curl-impersonate: A special build of curl that can impersonate Chrome & Firefox

MIT License

3.45k stars 229 forks source link

Docker update base images #168

Closed Alkarex closed 9 months ago

Alkarex commented 12 months ago

Hello, I noticed some Docker base images were getting a bit old, so:

Update to current versions: python:3.11-slim-bookworm, debian:bookworm-slim, alpine:3.18
Reduce size of Debian image (remove apt cache) by 10MB
~~Add pipefail (which I needed during test), cf. https://vaneyckt.io/posts/safer_bash_scripts_with_set_euxo_pipefail/~~
And also minor Markdown lint of INSTALL.md

lwthiker commented 11 months ago

Hi,

The build fails due to the Docker change. Is there any point in including it in the final images, if it's used mainly for debugging?

Alkarex commented 11 months ago

The build fails due to the Docker change. Is there any point in including it in the final images, if it's used mainly for debugging?

@lwthiker I have removed the pipefail instructions. If you like, I can make a new PR to propose them again. I believe it is useful in the final images to avoid the risks of having some instructions failing and going unnoticed.

Alkarex commented 11 months ago

@lwthiker Sorry I had not tested all build combinations. Should be fixed now 🤞🏻

wrobelda commented 10 months ago

Not a project owner, but this LGTM.