Closed gvanem closed 4 months ago
Applying the above patch, running with a modified .bat-file:
--signature-hashes ecdsa_secp256r1_sha256,rsa_pss_rsae_sha256,rsa_pkcs1_sha256,ecdsa_secp384r1_sha384 ^
--cert-compression brotli --http2-pseudo-headers-order "mspa"
shows no leaks for these option. So I ass-u-me my patch is good.
PS. very nice to see a --libcurl -
option dumps these new options:
...
curl_easy_setopt(hnd, CURLOPT_HTTP2_PSEUDO_HEADERS_ORDER, "mspa");
curl_easy_setopt(hnd, CURLOPT_SSL_SIG_HASH_ALGS, "ecdsa_secp256r1_sha256,rsa_pss_rsae_sha256,rsa_pkcs1_sha256,ecdsa_secp384r1_sha384");
curl_easy_setopt(hnd, CURLOPT_SSL_CERT_COMPRESSION, "brotli");
curl_easy_setopt(hnd, CURLOPT_SSLVERSION, (long)CURL_SSLVERSION_TLSv1_2);
curl_easy_setopt(hnd, CURLOPT_SSL_CIPHER_LIST, "TLS_AES_128_GCM_SHA256,TLS_AES_256_GCM_SHA384,TLS_CHACHA20_POLY1305_SHA256,ECDHE-ECDSA-AE
HACHA20-POLY1305,ECDHE-RSA-CHACHA20-POLY1305,ECDHE-RSA-AES128-SHA,ECDHE-RSA-AES256-SHA,AES128-GCM-SHA256,AES256-GCM-SHA384,AES128-SHA,AES25
Building on Win-10 (using MSVC or clang-cl) with
-DCURLDEBUG
and runningcurl-impersonate-chrome.exe
shows a small mem-leak for the option--cert-compression brotli
:Basically I did:
AFAICS, this variable (and the others) should be freed in
src/tool_cfgable.c
:But I see no patch for that file. An oversight?