lx-s / WinMute

WinMute lets you automatically mute your PC volume on certain events (e. g. Screensaver, Workstation Lock, Shutdown, etc.).
BSD 3-Clause "New" or "Revised" License
168 stars 6 forks source link

WinMute crashes without warning #16

Closed KemikalElite closed 2 years ago

KemikalElite commented 2 years ago

WinMute version: 2.1.1 Windows version: Win 10 Pro 64 21H2 19044.1889

Hello, I've noticed after a while WinMute will crash/close on its own. I can't yet find anything that will cause this. There is no error message or indication that the program has crashed. I notice it when I lock workstation as usual and the volume doesn't mute. I'll unlock and mouse over the icon in the taskbar and it will disappear. I only use the mute when workstation is locked or the screen turns off.

I've only been using this for a week so I can't tell if its caused by a new update or not. However its very useful to me as the mute toggle is something i probably use hundreds of times per year.

lx-s commented 2 years ago

Hi there,

thanks for your bug report. I'm running the same build as you, but did not notice any crashes. Could you enable logging and post me the log file? Maybe I can extract something from it. Just to be sure: You have all other options (Wi-Fi, Bluetooth, etc.) disabled?

I'm running the same Windows version and build as you and will try to see if I can reproduce it.

WuMyster commented 2 years ago

I have only just started using WinMute and have noticed that it crashes straight after it launches on startup. When opened manually, there is no issue with it. I have just turned on logging and will provide a log file soon.

WuMyster commented 2 years ago

Can't find the location of the log so will paste the contents here:

[2022-08-22 10:40:35] Mute Event: Workstation Lock start [2022-08-22 10:40:35] Saving mute status [2022-08-22 10:40:35] Muting workstation [2022-08-22 10:41:36] Mute Event: Display Standby start [2022-08-22 10:41:36] Muting event already active. Skipping status save [2022-08-22 10:44:37] Mute Event: Display Standby stop [2022-08-22 10:44:40] Mute Event: Workstation Lock stop [2022-08-22 10:44:40] Restoring previous mute state [2022-08-22 10:44:40] Restoring: Mute false for "Speakers (4- Schiit USB Audio Device)" [2022-08-22 10:44:40] Restoring: Mute false for "Speakers (NVIDIA Broadcast)" [2022-08-22 10:45:51] Starting new session... [2022-08-22 10:45:51] Found audio endpoint "Speakers (4- Schiit USB Audio Device)" [2022-08-22 10:45:51] Found audio endpoint "Speakers (NVIDIA Broadcast)" [2022-08-22 10:45:51] WinMute initialized [2022-08-22 10:53:20] Mute Event: Shutdown start [2022-08-22 15:23:36] Starting new session... [2022-08-22 15:23:36] Found audio endpoint "Speakers (4- Schiit USB Audio Device)" [2022-08-22 15:23:36] Found audio endpoint "Speakers (NVIDIA Broadcast)" [2022-08-22 15:23:36] WinMute initialized [2022-08-22 15:24:40] Mute Event: Display Standby start [2022-08-22 15:24:40] Saving mute status [2022-08-22 15:25:35] Mute Event: Display Standby stop [2022-08-22 15:25:39] Mute Event: Workstation Lock stop [2022-08-22 17:14:21] Starting new session... [2022-08-22 17:14:21] Found audio endpoint "Speakers (4- Schiit USB Audio Device)" [2022-08-22 17:14:21] Found audio endpoint "Speakers (NVIDIA Broadcast)" [2022-08-22 17:14:21] WinMute initialized

Turned my PC on at 15:23 and decided to check at 17:14 if WinMute was still running and it wasn't, so reopened.

KemikalElite commented 2 years ago

I figured out the cause. It crashes 100% when starting to host a remote desktop (RDP) session. I assume it has something to do with Windows replacing all audio devices with a virtual Remote Audio driver during connections.

EDIT: Sorry, didn't intend to close the issue. New to github.

lx-s commented 2 years ago

Thanks for looking further into the problem.

WinMute should handle that scenario without crashing

I’ll investigate!

WuMyster commented 2 years ago

Just to note, I am not using any form of remote desktop.

lx-s commented 2 years ago

I figured out the cause. It crashes 100% when starting to host a remote desktop (RDP) session. I assume it has something to do with Windows replacing all audio devices with a virtual Remote Audio driver during connections.

Could you give me a step-by-step, so I can reproduce this behaviour? In the past I've used Citrix on my company computer, but I've never hosted a RDP session on my own :)

Just to note, I am not using any form of remote desktop.

Alright.. Strange. I'll have to improve logging a bit, so I can catch more error situations. Right now it looks, as if it exited (if it crashed, you should normally see a Message Box telling you some error), right after your workstation lock. But I guess that there's something missing here.

KemikalElite commented 2 years ago

To enable Remote Desktop hosting: Start Menu > Settings > System > Remote Desktop (second from the bottom on the left) > Change Enable Remote Desktop to on. Please note that you need a password on your Windows account and this will not work on Home Edition.

For the client side you can connect from another Windows machine with the built in Remote Desktop client or download "Microsoft Remote Desktop" on iOS or Android. Once the client device is on the same local network you can enter either the host machine name or local IP address to connect to. You will be prompted to enter the user name and password. Remote Audio should be enabled by default. As soon as you connect to the remote session WinMute should close and you can verify this by mousing over the taskbar icon which will then disappear.

lx-s commented 2 years ago

Awesome thanks! Was able to reproduce it and fix the crash :)

You can find the release here: https://github.com/lx-s/WinMute/releases/tag/2.1.2.0

@WuMyster: Your problem might be also taken care of due to this change. If not, please don't hesitate to open a new ticket, so we can analyze the problem on your computer further.

WuMyster commented 2 years ago

Just to let you know, the new update seems to have fixed my crashing issues.

lx-s commented 2 years ago

Just to let you know, the new update seems to have fixed my crashing issues.

Glad to hear :)