Inno Setup installer script improvement

lx-s / WinMute

WinMute lets you automatically mute your PC volume on certain events (e. g. Screensaver, Workstation Lock, Shutdown, etc.).

BSD 3-Clause "New" or "Revised" License

168 stars 6 forks source link

Inno Setup installer script improvement #27

Closed bovirus closed 9 months ago

bovirus commented 11 months ago

@lx-s

Could you please add italian language to instalelr. hat version of InnOS etup instalelr are you using.

Pelase check screenshot

Is missing File version and copyright info.

About copyright version is important company name and staring and ending copyright year. Ending copyright year can get via date functiona nd automatically update.

Name: "autostart" ; Description: "Start WinMute when you log on" ; GroupDescription: "Autostart"; Flags: unchecked

Thie "description" string is untranslated. Please add it in Custom string.

I propose to move language and custom strings in a separate .iss file (and use #include in original .iss file to include it). In this way teh main script is untocuehd and any additional language changes are only in custom string file.

If you agree I can made all changes.

In Window program list is not sued program icon (use genric text icon).

lx-s commented 11 months ago

If you want, you can make a pull request :)

bovirus commented 11 months ago

@lx-s

Some request about improvemt.

For copyright message just put current year or do you want a year interval. ex

In prefer second option wht's the starting copyright year?

Info-before I propose to use this (new line for each paragraph)

info-before.txt

Could be possible to sue a info-before in italian for italian lnaguage?

License

For license I propose to format not it to 80 chars line. Like this

license-new.txt

Can be possible use for Italian language a localized version of the license?

Thanks.

lx-s commented 11 months ago

Copyright

2011-<current date>

Info-before

👍

license-new.txt

For the source code and the root LICENSE file, i prefer the 80 column version, as that is the cannonical it is written. Is that a problem for the installer? Afaik other projects show it also like this during the setup.

Can be possible use for Italian language a localized version of the license?

If you can find an official version of the license, otherwise i'd prefer it to be the original english text. As far as I can tell, there is no official version of the license for different languages (I also looked for a german version, but couldn't find one).

bovirus commented 11 months ago

@lx-s

Thanks.

License text layout

Personallly I consider 80 chars layout not modern. Was OK in the past for terminal layout (80x25). Is not the best one for current format for modernn license page. Pleaseecheck how can be with original and new mdoern layout without 80chars limitation.

Original

New layout (not limited to 80 chars).

All sapce sued. Easier to read (no forced new lines). New line to separate pragraph.

Localized license. For the license please consider by user point of view. To accept the license (just not to press OK) the suer should understand the "license agreement" ad then should be in local language (not all suer know english). Otherwise for many user that doesn't know english is just press "OK" to go away. The license can be localized (in German and Italian). Why not?
Info-before.txt localization

What's about "info-before.txt"? Coudl be localized?

lx-s commented 11 months ago

Hey there, i just merged your PR. Thanks for the work!

The next update for winmute will contain your setup changes, as well as the new translation infrastructure (that I am currently (slowly) working on).

bovirus commented 11 months ago

@lx-s

Thanks a lot.