Closed DasWookie closed 3 years ago
Cool idea! And should be fairly easy to implement. I'll look into this :)
Just implemented it! (10d093b2eb1342bb25b9aa6a0521941f54db314b...6e3f90bfbcadba15cd3fe49c7e866835435c1eac)
As I usually do, I let it run for a week or two, to see if there's any bugs, before making a release.
If you want to try it out yourself, you can grab it here (fresh from the compiler):
Thank you. I'll have a go and will report and bugs if I run into one.
Fixed some bugs, added some features:
I keep getting "loadlibrary failed with error 125l: the specified module could not be found." Trying to run 1.6 beta2. I have tried removing 1.5 but continued to receive error. Do we need to unregister the dll or something?
That's strange, since nothing should have changed in that regard between beta 1 and 2.
Could you try to install the current version of the Visual C++ Redistributable?
I installed and rebooted computer, no luck. 1.5 still works fine, 1.6 not.
Thanks for trying. I've set up a virtual machine with Windows 10 20H2 and confirmed the issue.
I've attached a new version that works on the VM. Could you try again with this version:
WinMute_1.6.0-beta2_x64.zip
Still don't know what exactly caused this issue...
Works now.
Maybe i'm missing something but the hours logic may be flawed. I tried to set quite time during sleep hours (10pm - 730am) it errors saying Invalid time range (Quiet Hrs must end before they start). Its not accounting for next day. I realize this will make the logic more complicated :) but maybe its still doable.
Yep - you are right. I got that logic backwards ;) New beta: WinMute_1.6.0-beta3_x64.zip
Hopefully it's the last beta :)
Not sure this was missed when you changed logic. Quiet time mutes at the right time but does not unmute. I tried with the "force unmute" checked or unchecked. Still doesnt unmute automatically.
Thanks :)
Hm. Do you restart your PC in-between? (I've tested it with my work PC (which runs 24/7) and It works as expected.)
Can't remember if I restarted. I will try again when I have a moment. More interested in a fix for the auto screen lock working to mute. That would just fix EVERYTHING for me and be super awesome hehe.
Thanks,
Byron S
On Thu, Nov 12, 2020 at 1:56 AM Alexander Steinhöfer < notifications@github.com> wrote:
Hm. Do you restart your PC in-between? (I've tested it with my work PC (which runs 24/7) and It works as expected.)
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lx-s/WinMute/issues/3#issuecomment-725880386, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKUGGISVWDYYNL4GHPBTI6TSPOBLNANCNFSM4SU2K6EA .
I think this feature is stable now (in my current development version). I'll have to fix the timing problems mentioned in #4 and then I'll release 1.6 sometime next week.
Thanks for your patience.
Cool, thanks so much!.
Because of #4 I'll postpone the release a bit more. If you want to use quiet hours now, you can use the beta attached in #4 though :)
Added in version 1.6.0
It would be terrific if the ability for the app to automatically mute during time periods. That way, say when working on a laptop late at night in bed, an unexpected audio event happens. This way, you could automatically set a time period to auto mute for "quite hours" at night so even if your device isn't locked, screensaver on, etc then audio would still be muted without you having to remember to do so until it's Ooooops, TOO late!