search

lxc / go-lxc

Go bindings for liblxc
https://linuxcontainers.org/lxc
Other
428 stars 77 forks source link

bug: Fix fd leak in go_lxc_clone #122

Closed theopolis closed 5 years ago

theopolis commented 5 years ago

I noticed that on success struct lxc_container *do_lxcapi_clone returns a reference-counted container that should be 'put' so that it is destroyed. Otherwise Clone leaks memory and descriptors.

stgraber commented 5 years ago

Hi,

All commits to the LXC projects need to be signed-off, you can do so by simply editing your commit message and adding a Signed-off-by: Firstname Lastname <email@address> line at the end of it.

git commit --amend -s may also do this for you, then followed by a force push.

Thanks!