search

lxc / go-lxc

Go bindings for liblxc
https://linuxcontainers.org/lxc
Other
430 stars 76 forks source link

go-lxc: update cgo build flags #133

Closed brauner closed 5 years ago

brauner commented 5 years ago

Use the same flags we require in LXD. Especially, hide all C functions to avoid symbol resolution clashes.

Signed-off-by: Christian Brauner christian.brauner@ubuntu.com

stgraber commented 5 years ago 
go build github.com/lxc/go-lxc: invalid flag in #cgo CFLAGS: -fvisibility=hidden
stgraber commented 5 years ago

This appears to fail to build with Go 1.10, as that's our main target Go version, that's a bit of a problem and needs solving.

brauner commented 5 years ago

This appears to fail to build with Go 1.10, as that's our main target Go version, that's a bit of a problem and needs solving.

grrr I have pushed a possible solution

stgraber commented 5 years ago

Now all Go versions are failing.

brauner commented 5 years ago

Now all Go versions are failing.

Think I found a fix now.