Fix the locking logic (v2)

caglar10ur commented 7 years ago

The original code where we were doing following

func X()  {
    call makesure
    makesure locks
    ...work
    makesure unlocks
    lock
    ...work
    unlock
}

was potentially racy as someone else could obtain the lock in between makesure and mutex.Lock call.

Changes since last attempt:

Running LXD tests locally ends up with success.


...
==> Deleting all storage pools
Storage pool lxdtest-cjU deleted
==> Checking for locked DB tables
==> Checking for leftover files
==> Checking for leftover DB entries
==> Tearing down directory backend in
/home/caglar/go/src/github.com/lxc/lxd/test/tmp.IQA/cjU

==> Test result: success ...

stgraber commented 7 years ago

cool, will take a look.

stgraber commented 7 years ago

Looks good to me, merging and throwing a re-try of all LXD tests just in case.

lxc / go-lxc

Fix the locking logic (v2) #91