search

lxc / go-lxc

Go bindings for liblxc
https://linuxcontainers.org/lxc
Other
431 stars 76 forks source link

container: add StartExecute() #95

Closed brauner closed 6 years ago

brauner commented 7 years ago

This is an API-only version of Execute().

Closes #83.

Signed-off-by: Christian Brauner christian.brauner@ubuntu.com

caglar10ur commented 7 years ago

Do we need the conditional in the Execute as well (see below)?

if VersionAtLeast(2, 1, 0) {
...

Also how about replacing the Execute if this works properly now?

brauner commented 6 years ago

Do we need the conditional in the Execute as well (see below)?

I don't think so.

Also how about replacing the Execute if this works properly now?

This is not so nice since the current Execute() returns a tuple. But we could probably always return []byte as nil.

caglar10ur commented 6 years ago

makes sense

LGTM