search

lxc / incus

Powerful system container and virtual machine manager
https://linuxcontainers.org/incus
Apache License 2.0
2.8k stars 224 forks source link

exec: Consume websocket pings for stderr #1380

Closed stefanor closed 1 week ago

stefanor commented 1 week ago

Fixes: #1289

stgraber commented 1 week ago

@stefanor could you update the commit message to include the Signed-off-by line?

stgraber commented 1 week ago

Very nice catch. I had started to look into this a few weeks ago, but the time needed to reproduce and debug was a bit annoying :)

stefanor commented 1 week ago

Very nice catch. I had started to look into this a few weeks ago, but the time needed to reproduce and debug was a bit annoying :)

@cjwatson pointed me in the right direction, because he'd debugged something similar before. Once I knew what to look for, it was obvious what was missing.

stgraber commented 1 week ago

Thanks!

stefanor commented 1 week ago

Would you mind cherry-picking this into the stable-6.0 branch?