hanskuhn commented 8 months ago

Hi! Thanks for the awesome work to keep my favorite container software alive. I've started to migrate from LXD to Incus and ran into a hiccup. I was able to work around my problem, but wanted to share my experience in case it's useful. Let me know if more information is needed.

Thanks!

Required information

Distribution: Ubuntu LTS
Distribution version: 20.04.6

The output of "incus info" or if that fails:

config: {}
api_extensions:
- storage_zfs_remove_snapshots
- container_host_shutdown_timeout
- container_stop_priority
- container_syscall_filtering
- auth_pki
- container_last_used_at
- etag
- patch
- usb_devices
- https_allowed_credentials
- image_compression_algorithm
- directory_manipulation
- container_cpu_time
- storage_zfs_use_refquota
- storage_lvm_mount_options
- network
- profile_usedby
- container_push
- container_exec_recording
- certificate_update
- container_exec_signal_handling
- gpu_devices
- container_image_properties
- migration_progress
- id_map
- network_firewall_filtering
- network_routes
- storage
- file_delete
- file_append
- network_dhcp_expiry
- storage_lvm_vg_rename
- storage_lvm_thinpool_rename
- network_vlan
- image_create_aliases
- container_stateless_copy
- container_only_migration
- storage_zfs_clone_copy
- unix_device_rename
- storage_lvm_use_thinpool
- storage_rsync_bwlimit
- network_vxlan_interface
- storage_btrfs_mount_options
- entity_description
- image_force_refresh
- storage_lvm_lv_resizing
- id_map_base
- file_symlinks
- container_push_target
- network_vlan_physical
- storage_images_delete
- container_edit_metadata
- container_snapshot_stateful_migration
- storage_driver_ceph
- storage_ceph_user_name
- resource_limits
- storage_volatile_initial_source
- storage_ceph_force_osd_reuse
- storage_block_filesystem_btrfs
- resources
- kernel_limits
- storage_api_volume_rename
- network_sriov
- console
- restrict_dev_incus
- migration_pre_copy
- infiniband
- dev_incus_events
- proxy
- network_dhcp_gateway
- file_get_symlink
- network_leases
- unix_device_hotplug
- storage_api_local_volume_handling
- operation_description
- clustering
- event_lifecycle
- storage_api_remote_volume_handling
- nvidia_runtime
- container_mount_propagation
- container_backup
- dev_incus_images
- container_local_cross_pool_handling
- proxy_unix
- proxy_udp
- clustering_join
- proxy_tcp_udp_multi_port_handling
- network_state
- proxy_unix_dac_properties
- container_protection_delete
- unix_priv_drop
- pprof_http
- proxy_haproxy_protocol
- network_hwaddr
- proxy_nat
- network_nat_order
- container_full
- backup_compression
- nvidia_runtime_config
- storage_api_volume_snapshots
- storage_unmapped
- projects
- network_vxlan_ttl
- container_incremental_copy
- usb_optional_vendorid
- snapshot_scheduling
- snapshot_schedule_aliases
- container_copy_project
- clustering_server_address
- clustering_image_replication
- container_protection_shift
- snapshot_expiry
- container_backup_override_pool
- snapshot_expiry_creation
- network_leases_location
- resources_cpu_socket
- resources_gpu
- resources_numa
- kernel_features
- id_map_current
- event_location
- storage_api_remote_volume_snapshots
- network_nat_address
- container_nic_routes
- cluster_internal_copy
- seccomp_notify
- lxc_features
- container_nic_ipvlan
- network_vlan_sriov
- storage_cephfs
- container_nic_ipfilter
- resources_v2
- container_exec_user_group_cwd
- container_syscall_intercept
- container_disk_shift
- storage_shifted
- resources_infiniband
- daemon_storage
- instances
- image_types
- resources_disk_sata
- clustering_roles
- images_expiry
- resources_network_firmware
- backup_compression_algorithm
- ceph_data_pool_name
- container_syscall_intercept_mount
- compression_squashfs
- container_raw_mount
- container_nic_routed
- container_syscall_intercept_mount_fuse
- container_disk_ceph
- virtual-machines
- image_profiles
- clustering_architecture
- resources_disk_id
- storage_lvm_stripes
- vm_boot_priority
- unix_hotplug_devices
- api_filtering
- instance_nic_network
- clustering_sizing
- firewall_driver
- projects_limits
- container_syscall_intercept_hugetlbfs
- limits_hugepages
- container_nic_routed_gateway
- projects_restrictions
- custom_volume_snapshot_expiry
- volume_snapshot_scheduling
- trust_ca_certificates
- snapshot_disk_usage
- clustering_edit_roles
- container_nic_routed_host_address
- container_nic_ipvlan_gateway
- resources_usb_pci
- resources_cpu_threads_numa
- resources_cpu_core_die
- api_os
- container_nic_routed_host_table
- container_nic_ipvlan_host_table
- container_nic_ipvlan_mode
- resources_system
- images_push_relay
- network_dns_search
- container_nic_routed_limits
- instance_nic_bridged_vlan
- network_state_bond_bridge
- usedby_consistency
- custom_block_volumes
- clustering_failure_domains
- resources_gpu_mdev
- console_vga_type
- projects_limits_disk
- network_type_macvlan
- network_type_sriov
- container_syscall_intercept_bpf_devices
- network_type_ovn
- projects_networks
- projects_networks_restricted_uplinks
- custom_volume_backup
- backup_override_name
- storage_rsync_compression
- network_type_physical
- network_ovn_external_subnets
- network_ovn_nat
- network_ovn_external_routes_remove
- tpm_device_type
- storage_zfs_clone_copy_rebase
- gpu_mdev
- resources_pci_iommu
- resources_network_usb
- resources_disk_address
- network_physical_ovn_ingress_mode
- network_ovn_dhcp
- network_physical_routes_anycast
- projects_limits_instances
- network_state_vlan
- instance_nic_bridged_port_isolation
- instance_bulk_state_change
- network_gvrp
- instance_pool_move
- gpu_sriov
- pci_device_type
- storage_volume_state
- network_acl
- migration_stateful
- disk_state_quota
- storage_ceph_features
- projects_compression
- projects_images_remote_cache_expiry
- certificate_project
- network_ovn_acl
- projects_images_auto_update
- projects_restricted_cluster_target
- images_default_architecture
- network_ovn_acl_defaults
- gpu_mig
- project_usage
- network_bridge_acl
- warnings
- projects_restricted_backups_and_snapshots
- clustering_join_token
- clustering_description
- server_trusted_proxy
- clustering_update_cert
- storage_api_project
- server_instance_driver_operational
- server_supported_storage_drivers
- event_lifecycle_requestor_address
- resources_gpu_usb
- clustering_evacuation
- network_ovn_nat_address
- network_bgp
- network_forward
- custom_volume_refresh
- network_counters_errors_dropped
- metrics
- image_source_project
- clustering_config
- network_peer
- linux_sysctl
- network_dns
- ovn_nic_acceleration
- certificate_self_renewal
- instance_project_move
- storage_volume_project_move
- cloud_init
- network_dns_nat
- database_leader
- instance_all_projects
- clustering_groups
- ceph_rbd_du
- instance_get_full
- qemu_metrics
- gpu_mig_uuid
- event_project
- clustering_evacuation_live
- instance_allow_inconsistent_copy
- network_state_ovn
- storage_volume_api_filtering
- image_restrictions
- storage_zfs_export
- network_dns_records
- storage_zfs_reserve_space
- network_acl_log
- storage_zfs_blocksize
- metrics_cpu_seconds
- instance_snapshot_never
- certificate_token
- instance_nic_routed_neighbor_probe
- event_hub
- agent_nic_config
- projects_restricted_intercept
- metrics_authentication
- images_target_project
- cluster_migration_inconsistent_copy
- cluster_ovn_chassis
- container_syscall_intercept_sched_setscheduler
- storage_lvm_thinpool_metadata_size
- storage_volume_state_total
- instance_file_head
- instances_nic_host_name
- image_copy_profile
- container_syscall_intercept_sysinfo
- clustering_evacuation_mode
- resources_pci_vpd
- qemu_raw_conf
- storage_cephfs_fscache
- network_load_balancer
- vsock_api
- instance_ready_state
- network_bgp_holdtime
- storage_volumes_all_projects
- metrics_memory_oom_total
- storage_buckets
- storage_buckets_create_credentials
- metrics_cpu_effective_total
- projects_networks_restricted_access
- storage_buckets_local
- loki
- acme
- internal_metrics
- cluster_join_token_expiry
- remote_token_expiry
- init_preseed
- storage_volumes_created_at
- cpu_hotplug
- projects_networks_zones
- network_txqueuelen
- cluster_member_state
- instances_placement_scriptlet
- storage_pool_source_wipe
- zfs_block_mode
- instance_generation_id
- disk_io_cache
- amd_sev
- storage_pool_loop_resize
- migration_vm_live
- ovn_nic_nesting
- oidc
- network_ovn_l3only
- ovn_nic_acceleration_vdpa
- cluster_healing
- instances_state_total
- auth_user
- security_csm
- instances_rebuild
- numa_cpu_placement
- custom_volume_iso
- network_allocations
- zfs_delegate
- storage_api_remote_volume_snapshot_copy
- operations_get_query_all_projects
- metadata_configuration
- syslog_socket
- event_lifecycle_name_and_project
- instances_nic_limits_priority
- disk_initial_volume_configuration
- operation_wait
- image_restriction_privileged
- cluster_internal_custom_volume_copy
- disk_io_bus
- storage_cephfs_create_missing
- instance_move_config
- ovn_ssl_config
- certificate_description
api_status: stable
api_version: "1.0"
auth: trusted
public: false
auth_methods:
- tls
auth_user_name: <snip>
auth_user_method: unix
environment:
addresses: []
architectures:
- x86_64
- i686
certificate: |
-----BEGIN CERTIFICATE-----
<snip>
-----END CERTIFICATE-----
certificate_fingerprint: <snip>
driver: lxc | qemu
driver_version: 5.0.3 | 8.1.3
firewall: xtables
kernel: Linux
kernel_architecture: x86_64
kernel_features:
idmapped_mounts: "true"
netnsid_getifaddrs: "true"
seccomp_listener: "true"
seccomp_listener_continue: "true"
uevent_injection: "true"
unpriv_fscaps: "true"
kernel_version: 5.15.0-91-generic
lxc_features:
cgroup2: "true"
core_scheduling: "true"
devpts_fd: "true"
idmapped_mounts_v2: "true"
mount_injection_file: "true"
network_gateway_device_route: "true"
network_ipvlan: "true"
network_l2proxy: "true"
network_phys_macvlan_mtu: "true"
network_veth_router: "true"
pidfd: "true"
seccomp_allow_deny_syntax: "true"
seccomp_notify: "true"
seccomp_proxy_send_notify_fd: "true"
os_name: Ubuntu
os_version: "20.04"
project: default
server: incus
server_clustered: false
server_event_mode: full-mesh
server_name: lxd0
server_pid: 1429
server_version: "0.4"
storage: btrfs | zfs
storage_version: 5.4.1 | 0.8.3-1ubuntu12.16
storage_supported_drivers:
- name: btrfs
version: 5.4.1
remote: false
- name: dir
version: "1"
remote: false
- name: lvm
version: 2.03.07(2) (2019-11-30) / 1.02.167 (2019-11-30) / 4.45.0
remote: false
- name: zfs
version: 0.8.3-1ubuntu12.16
remote: false

Issue description

This is a conversion from LXD -> Incus using the lxd-to-incus script. The incus-lxcfs.service fails to start because 'mkdir' isn't found.

I confirmed that a symlink from /bin/mkdir to /usr/bin/mkdir fixes the problem and allows the incus-lxcfs.service to start.

I looked at the coreutils pkg and it appears that /bin/mkdir is the expected location for this binary.

Steps to reproduce

Install incus from the zabbly repo
Run lxd-to-incus
journalctl -u incus-lxcfs.service to see the error when mkdir isn't found.

Information to attach

$ journalctl -u incus-lxcfs

Dec 31 02:50:11 lxd0 systemd[1]: Starting Incus - LXCFS daemon...
Dec 31 02:50:11 lxd0 systemd[995124]: incus-lxcfs.service: Executable /usr/bin/mkdir missing, skipping: No such file or directory
Dec 31 02:50:11 lxd0 systemd[1]: Started Incus - LXCFS daemon.
Dec 31 02:50:11 lxd0 lxcfs[995125]: Running constructor lxcfs_init to reload liblxcfs
Dec 31 02:50:11 lxd0 lxcfs[995125]: mount namespace: 4
Dec 31 02:50:11 lxd0 lxcfs[995125]: hierarchies:
Dec 31 02:50:11 lxd0 lxcfs[995125]:   0: fd:   5:
Dec 31 02:50:11 lxd0 lxcfs[995125]:   1: fd:   6: name=systemd
Dec 31 02:50:11 lxd0 lxcfs[995125]:   2: fd:   7: freezer
Dec 31 02:50:11 lxd0 lxcfs[995125]:   3: fd:   8: cpuset
Dec 31 02:50:11 lxd0 lxcfs[995125]:   4: fd:   9: net_cls,net_prio
Dec 31 02:50:11 lxd0 lxcfs[995125]:   5: fd:  10: pids
Dec 31 02:50:11 lxd0 lxcfs[995125]:   6: fd:  11: memory
Dec 31 02:50:11 lxd0 lxcfs[995125]:   7: fd:  12: rdma
Dec 31 02:50:11 lxd0 lxcfs[995125]:   8: fd:  13: perf_event
Dec 31 02:50:11 lxd0 lxcfs[995125]:   9: fd:  14: cpu,cpuacct
Dec 31 02:50:11 lxd0 lxcfs[995125]:  10: fd:  15: devices
Dec 31 02:50:11 lxd0 lxcfs[995125]:  11: fd:  16: hugetlb
Dec 31 02:50:11 lxd0 lxcfs[995125]:  12: fd:  17: misc
Dec 31 02:50:11 lxd0 lxcfs[995125]:  13: fd:  18: blkio
Dec 31 02:50:11 lxd0 lxcfs[995125]: Kernel supports pidfds
Dec 31 02:50:11 lxd0 lxcfs[995125]: Kernel supports swap accounting
Dec 31 02:50:11 lxd0 lxcfs[995125]: api_extensions:
Dec 31 02:50:11 lxd0 lxcfs[995125]: - cgroups
Dec 31 02:50:11 lxd0 lxcfs[995125]: - sys_cpu_online
Dec 31 02:50:11 lxd0 lxcfs[995125]: - proc_cpuinfo
Dec 31 02:50:11 lxd0 lxcfs[995125]: - proc_diskstats
Dec 31 02:50:11 lxd0 lxcfs[995125]: - proc_loadavg
Dec 31 02:50:11 lxd0 lxcfs[995125]: - proc_meminfo
Dec 31 02:50:11 lxd0 lxcfs[995125]: - proc_stat
Dec 31 02:50:11 lxd0 lxcfs[995125]: - proc_swaps
Dec 31 02:50:11 lxd0 lxcfs[995125]: - proc_uptime
Dec 31 02:50:11 lxd0 lxcfs[995125]: - proc_slabinfo
Dec 31 02:50:11 lxd0 lxcfs[995125]: - shared_pidns
Dec 31 02:50:11 lxd0 lxcfs[995125]: - cpuview_daemon
Dec 31 02:50:11 lxd0 lxcfs[995125]: - loadavg_daemon
Dec 31 02:50:11 lxd0 lxcfs[995125]: - pidfds
Dec 31 02:50:11 lxd0 lxcfs[995125]: ../src/lxcfs.c: 1152: set_pidfile: PID file '/run/lxcfs.pid' is already locked
Dec 31 02:50:11 lxd0 lxcfs[995125]: Running destructor lxcfs_exit
Dec 31 02:50:12 lxd0 systemd[1]: incus-lxcfs.service: Main process exited, code=exited, status=1/FAILURE
Dec 31 02:50:12 lxd0 fusermount[995152]: /bin/fusermount: failed to unmount /var/lib/incus-lxcfs: No such file or directory
Dec 31 02:50:12 lxd0 systemd[1]: incus-lxcfs.service: Failed with result 'exit-code'.
Dec 31 02:50:12 lxd0 systemd[1]: incus-lxcfs.service: Scheduled restart job, restart counter is at 1.
Dec 31 02:50:12 lxd0 systemd[1]: Stopped Incus - LXCFS daemon.

stgraber commented 8 months ago

Ah, your system but be an old Ubuntu release which was updated to Ubuntu 20.04 as Ubuntu 20.04 ships with /bin being a symlink to /usr/bin so this wouldn't have been a problem.

Anyway, as /bin is a symlink to /usr/bin on all modern systems, there's no real harm in using /bin/mkdir so I'll be doing that now.

stgraber commented 8 months ago

Fix pushed to daily and stable packaging repos (zabbly/incus), it will take a few days before it rolls out to users.

hanskuhn commented 8 months ago

Ah, your system but be an old Ubuntu release which was updated to Ubuntu 20.04 as Ubuntu 20.04 ships with /bin being a symlink to /usr/bin so this wouldn't have been a problem.

Anyway, as /bin is a symlink to /usr/bin on all modern systems, there's no real harm in using /bin/mkdir so I'll be doing that now.

Yep! The VM was an 18.04 that got upgraded to 20.04. Good sleuthing. Thanks for all the great work!

lxc / incus

incus-lxcfs can't find /usr/bin/mkdir #352

Required information

Issue description

Steps to reproduce

Information to attach