lxc / lxc-templates

Old style template scripts for LXC (prefer distrobuilder)
GNU Lesser General Public License v2.1
54 stars 56 forks source link

Improvements and bugfixes to templates/lxc-devuan.in and templates/lxc-kali.in #31

Closed TanyaEleventhGoddess closed 4 years ago

TanyaEleventhGoddess commented 4 years ago

replaces: #29 Various improvements and bugfixes for debian and kali templates figured out or taken from the work of Greg Olsen. Little note, in last merge with a kali template repo you didn't add lxc-kali in templates/Makefile.am and kali common/userns configs to config/Makefile.am. You also didn't change permissions of templates/lxc-kali.in from 755 to 644

I don't know if it's intentional or not, in doubt I didn't change anything and just advised

stgraber commented 4 years ago

Some of your commits are missing the required Signed-off-by: line.

This is normally added automatically using git commit -s. You can do it on multiple commits with something like git rebase origin --signoff followed with git push --force

TanyaEleventhGoddess commented 4 years ago

Done, you can proceed

stgraber commented 4 years ago

Thanks!