Allows setting of multiple network devices at creation.

lxc / python3-lxc

Python 3.x binding for liblxc

https://linuxcontainers.org/lxc

GNU Lesser General Public License v2.1

57 stars 38 forks source link

Closed michaelsatanovsky closed 3 years ago

michaelsatanovsky commented 3 years ago

[Work in progress PR]

Fixes #17

Crash when attempting to set multiple network devices using Python bindings during container creation.

Changes:

`ContainerNetworkList.__getitem__()' will create a new network by calling 'ContainerNetworkList.add()' if the requested index is not in bounds.

Signed-off-by: Michael Satanovsky michael.satanovsky@gmail.com

stgraber commented 3 years ago

Can you rebase this branch down to a single commit?

stgraber commented 3 years ago

Seems fine, ran the API test and things are passing and so is the suggested test in #17.