search

lxc / ruby-lxc

ruby bindings for liblxc
https://linuxcontainers.org/lxc
GNU Lesser General Public License v2.1
133 stars 29 forks source link

Correcting compilation for the last lxc development version. #20

Closed akerouanton closed 10 years ago

akerouanton commented 10 years ago

Hi,

This commit breaks compilation with master branch of lxc : the bdev_specs struct has been added to the lxccontainer.h.

I propose to add a new branch that will be dedicated to keep compatibility with the lxc version in ubuntu repository.

andrenth commented 10 years ago

My idea was to keep master in sync with lxc's master branch, and the other branches (eg. 1.1.x) compatible with the current ubuntu package. This might be harder than I initially thought though... I'll merge this into master for now and give it some more thought.

akerouanton commented 10 years ago

Oh, I had not seen the others branches ! Can you bump version 1.2 from master ? I will make some more PRs for fixing travis build and completing the readme for this.

andrenth commented 10 years ago

I'll wait a bit until an LXC version with that change is released, otherwise there'll be too many branches to manage. The change is in LXC's stable-1.0 branch, so I suspect it'll be available in 1.0.4 when it's released.

akerouanton commented 10 years ago

The master branch can be used only by compiling and installing the gem manually ? I am not really proposing to add a new branch (I had not seen the current 1.1.x branch) that need to be maintain, just a different version (in the gemspec) to the current master. In that way the module can be used with both ubuntu package and daily built package, without any drawbacks.

andrenth commented 10 years ago

Ok, I got it now. Version in master updated to 1.2.0.

On Mon, Jun 9, 2014 at 4:24 PM, Albin Kerouanton notifications@github.com wrote:

The master branch can be used only by compiling and installing the gem manually ? I am not really proposing to add a new branch (I had not seen the current 1.1.x branch) that need to be maintain, just a different version (in the gemspec) to the current master. In that way the module can be used with both ubuntu package and daily built package, without any drawbacks.

— Reply to this email directly or view it on GitHub https://github.com/lxc/ruby-lxc/pull/20#issuecomment-45532728.