Resource naming consistency

lxc / terraform-provider-incus

Incus provider for Terraform/OpenTofu

https://linuxcontainers.org/incus

Mozilla Public License 2.0

35 stars 8 forks source link

Resource naming consistency #49

Closed maveonair closed 3 months ago

maveonair commented 3 months ago

This pull request includes changes by renaming resource names and modifying the corresponding documentation and test files. The changes aim to improve clarity and consistency in the codebase as listed in https://github.com/lxc/terraform-provider-incus/issues/39.

Renamed resources:

incus_cached_image to incus_image
incus_publish_image to incus_image_publish
incus_snapshot to incus_instance_snapshot
incus_volume to incus_storage_volume
incus_volume_copy to incus_storage_volume_copy

adamcstephens commented 3 months ago

I'm fine with this but it will be a breaking change so should be versioned accordingly.

maveonair commented 3 months ago

I'm fine with this but it will be a breaking change so should be versioned accordingly.

Absolutely.

@stgraber How were you going to get away with a minor version change here, as you mentioned in the issue :D?

stgraber commented 3 months ago

I was thinking to do 0.2 once this is in. So a minor bump instead of a micro bump.

If we had been on a non-zero major, I'd have seen this one as requiring a major bump, but in our case, we're still slowly working towards our 1.0.