lxc / terraform-provider-incus

Incus provider for Terraform/OpenTofu
https://linuxcontainers.org/incus
Mozilla Public License 2.0
35 stars 8 forks source link

FIX: incus_storage_bucket produces inconsistent result #51

Closed maveonair closed 3 months ago

maveonair commented 3 months ago

This pull request fixes the situation where incus_storage_bucket produces an inconsistent result when using the lvm storage driver, see https://github.com/lxc/terraform-provider-incus/issues/47.

The same solution is already used in other resources, e.g:

stgraber commented 3 months ago

We can probably share some of that logic with the volume issue we have open as both are basically the same where volume.XYZ keys set on the pool will propagate to new volumes or buckets.

stgraber commented 3 months ago

So basically it's safe to ignore any key the user didn't define so long as the key and value line up with the matching volume.XYZ key on the pool.