search

lxde / lxterminal

VTE terminal emulator written in GTK
GNU General Public License v2.0
159 stars 56 forks source link

Updated building instruction (Ubuntu) #28

Closed TotalCaesar659 closed 7 years ago

TotalCaesar659 commented 7 years ago

Added more required packages. "apt-get build-dep lxterminal" may not be executed, because it shows the mistake "E: You must put some 'source' URIs in your source.list". I don't know what is it, so I didn't remove it just in case. This instruction was tested on Lubuntu 16.04.1 LTS x64.

medicalwei commented 7 years ago

In Debian/Ubuntu it is needed to add deb-src line into /etc/apt/sources.list get the package building information and source code tarball.

I will review that later.

Yao Wei, sending this on a phone

On 13 Dec 2016, at 08:11, TotalCaesar659 notifications@github.com wrote:

Added more required packages. "apt-get build-dep lxterminal" may not be executed, because it shows the mistake "E: You must put some 'source' URIs in your source.list". I don't know what is it, so I didn't remove it just in case. This instruction was tested on Lubuntu 16.04.1 LTS x64.

You can view, comment on, or merge this pull request online at:

https://github.com/lxde/lxterminal/pull/28

Commit Summary

Updated building instruction (Ubuntu) File Changes

M README.md (12) Patch Links:

https://github.com/lxde/lxterminal/pull/28.patch https://github.com/lxde/lxterminal/pull/28.diff ― You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

TotalCaesar659 commented 7 years ago

Ah, OK, thanks. But then it may be good to add a special note for this command or even move it to a separate part. I've successfully compiled LXTerminal without it.

medicalwei commented 7 years ago

Could you see if the updated version is much descriptive than before for build process?

TotalCaesar659 commented 7 years ago

Sorry, I don't understand the question. What does it mean "much descriptive" and what do I have to do for looking? I've just added more packages (LXTerminal just can't be compiled without them), I have a doubt that it became "much descriptive". And I see "This branch has conflicts that must be resolved". But pushing the button shows me 404. Is it normal?

medicalwei commented 7 years ago

I have updated README.md, which also causes conflicts: https://github.com/lxde/lxterminal/blob/master/README.md

TotalCaesar659 commented 7 years ago

Ah, thanks, your version is more better and it can be merged. But I want to specify: you've already made the list with all dependencies, so it doesn't required to write the partial command "sudo apt install git xsltproc docbook-xml docbook-xsl" - "sudo apt install git" is enough. Or, if you want to write the command for full install, it should be better to write "sudo apt install autotools-dev docbook-xml docbook-xsl intltool git libglib2.0-dev libgtk2.0-dev libvte-dev xsltproc".