search

lxde / lxterminal

VTE terminal emulator written in GTK
GNU General Public License v2.0
161 stars 57 forks source link

Add support for "bold is bright" setting #70

Closed koro666 closed 4 years ago

koro666 commented 5 years ago

VTE 0.52 added "bold is bright" setting with the vte_terminal_set_bold_is_bright function, and subsequently turned it off by default in 0.56.

This adds the setting to LXTerminal as well as the UI to control it.

koro666 commented 4 years ago

What do I need to do to get this merged?

FinboySlick commented 4 years ago

Sorry about the delay. The only issue I see is the possible confusion regarding the setting being 'disabled' if the VTE version isn't high enough. It may be better to make the entire patch conditional to the version, even though it might then add some temporary clutter to the code until the VTE requirement supersedes the version checks.

koro666 commented 4 years ago

Thanks for your feedback. Made the widgets hidden instead of disabled.