lxde / lxterminal

VTE terminal emulator written in GTK
GNU General Public License v2.0
159 stars 55 forks source link

[Patch] man/lxterminal.xml: description of -t and --title is wrong. Add description for help and version. #97

Open ZjYwMj opened 3 years ago

ZjYwMj commented 3 years ago

For

$ lxterminal -v
lxterminal 0.4.0

The following patch

  1. Fixes descriptions of -t and --title in the manual page. Compare it with lxterminal -h.
  2. Add entries for the help and version options.
    
    --- a/man/lxterminal.xml    2021-06-13 17:27:50.173982416 +0000
    +++ b/man/lxterminal.xml    2021-06-13 17:27:08.264651478 +0000
    @@ -55,17 +55,24 @@
    <listitem>    <para>Set the terminal's size in characters and lines.</para>
    </listitem>
       </varlistentry>
    +      <varlistentry>   <term>    <option>-h</option>
    +     <option>--help</option>
    +   </term>fixes
    +   <listitem>    <para>Prints a short help message, and exit.</para>
    +   </listitem>
    +      </varlistentry>
       <varlistentry>   <term>    <option>-l</option>
      <option>--loginshell</option>
    </term>
    <listitem>    <para>Executes login shell.</para>
    </listitem>
       </varlistentry>
    -      <varlistentry>   <term>    <option>-t <replaceable>NAME[,NAME[,NAME[...]]]</replaceable></option>
    -     <option>--title=<replaceable>NAME[,NAME[,NAME[...]]]</replaceable></option>
    +      <varlistentry>   <term>    <option>-T <replaceable>NAME</replaceable></option>
    +     <option>-t <replaceable>NAME</replaceable></option>
    +     <option>--title=<replaceable>NAME</replaceable></option>
    +     <option>--tabs=<replaceable>NAME,NAME[,NAME[...]]</replaceable></option>
    </term>
    -   <listitem>    <para>Set the terminal's title. Use comma for multiple tabs.</para>
    +   <listitem>    <para>Set the terminal's title. Comma separated multiple titles create multiple tabs only with the <option>--tabs=</option> form.</para>
    </listitem>
       </varlistentry>
       <varlistentry>        <term>          <option>--working-directory=<replaceable>DIRECTORY</replaceable></option>
    @@ -73,6 +80,12 @@
         <listitem>          <para>Set the terminal's working directory.</para>
         </listitem>
       </varlistentry>
    +      <varlistentry>   <term>    <option>-v</option>
    +     <option>--version</option>
    +   </term>
    +   <listitem>    <para>Prints version information, and exit.</para>
    +   </listitem>
    +      </varlistentry>
     </variablelist>
    </refsect1>
FinboySlick commented 3 years ago

Thank you. Would you like to add this as a pull request to maintain credit?

ZjYwMj commented 3 years ago

As far as I can tell, I have right now added it as a pull request.

ZjYwMj commented 3 years ago

I have modified the patch some few minutes ago. Actually, It is probably better if I will update my lxterminal repository. I will get to that now. I will explain what I did at the comment in my lxterminal repository.