lxn / walk

A Windows GUI toolkit for the Go Programming Language
Other
6.84k stars 884 forks source link

tableview: return column count #600

Closed zx2c4 closed 5 years ago

zx2c4 commented 5 years ago

NVDA requests LVIF_COLUMNS too when probing.


This is @rozmansi's commit. I don't fully grok what's going on here and haven't looked into it yet, but perhaps he can chime in with more context.

rozmansi commented 5 years ago

Researching NVDA source code, I have discovered it also queries for LVIF_COLUMNS. Since TableView has a perfectly obtainable column count, why not support this?

lxn commented 5 years ago

Not sure how this should work. Are column counts of frozen and normal listviews to be reported separately? tv.visibleColumnCount() also includes frozen columns.

rozmansi commented 5 years ago

I have read the documentation more carefully and this commit is totally wrong. Can somebody please close/delete it?

https://docs.microsoft.com/en-us/windows/win32/api/commctrl/ns-commctrl-lvitema:

Number of data columns (subitems) to display for this item in tile view. The maximum value is 20. If this value is I_COLUMNSCALLBACK, the size of the column array and the array itself (puColumns) are obtained by sending a LVN_GETDISPINFO notification.