search

lxn / walk

A Windows GUI toolkit for the Go Programming Language
Other
6.8k stars 885 forks source link

Icon: Switch to LoadIconWithScaleDown() #642

Closed rozmansi closed 4 years ago

rozmansi commented 4 years ago

Legacy LoadImage() picks a smaller icon variant and scales it up when the desired size is not available. LoadIconWithScaleDown() introduced in Windows Vista picks a larger icon variant and scales it down producing slightly better results.

Green7 commented 3 years ago

This change also does not work on Windows Vista, and Windows 7 32 bit. I checked and on these systems, I was unable to call LoadIconWithScaleDown without error. I have no idea why ... Old version with LoadImage works. Perhaps LoadImage should be called when LoadIconWithScaleDown fails?

rozmansi commented 3 years ago

Unfortunately, I do not keep any of those ancient Windows versions around anymore. Therefore, I am not able to test and fix this.

Green7 commented 3 years ago

It is possible that this same problem exists on Windows 10 32 bit. I'll try to check it out. I can also do some tests if you want (just send me the code) - but as I wrote: LoadIconWithScaleDown doesn't work ...