lxndrblz / anatole

Anatole is a minimalistic two-column theme for Hugo.
https://themes.gohugo.io/themes/anatole/
MIT License
651 stars 363 forks source link

Set open graph meta tags without requiring series taxonomy #327

Closed alexanderdavide closed 2 years ago

alexanderdavide commented 2 years ago

Description

Currently, Open Graph is only set when the series taxonomy is used. This is an inopportune default which this PR addresses.

Citing @Xen-Echo from #166:

Testing locally the open graph template only fails to render if you have pages with "series" front matter and haven't also specified the corresponding "series" taxonomy. I personally don't think this should stop the open graph template rendering though as you lose the basic open graph fields like image etc. when you copy a page link somewhere that supports rich URLs.

Whoever sets series in front mattter configs without having the series taxonomy enabled in the site configuration should not be 'protected'.

Issue Number:

166


Checklist

Yes, I included all necessary artefacts, including:


Testing Checklist

Yes, I ensured that all of the following scenarios were tested:


Notify the following users

netlify[bot] commented 2 years ago

✔️ Deploy Preview for anatole-demo ready!

🔨 Explore the source changes: 579d7682f2c91dc7d36e5f028ee999e91c3e8265

🔍 Inspect the deploy log: https://app.netlify.com/sites/anatole-demo/deploys/622e15d0a8952b0009eec06a

😎 Browse the preview: https://deploy-preview-327--anatole-demo.netlify.app

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication