Closed wooshcz closed 2 years ago
Name | Link |
---|---|
Latest commit | fea62868f99140b16d9c49f71d5a80ea29bf5afc |
Latest deploy log | https://app.netlify.com/sites/anatole-demo/deploys/62403d4ded262600084bfe37 |
Deploy Preview | https://deploy-preview-334--anatole-demo.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
@wooshcz I had a wee look already and it looks like three useful improvements. Thanks for the PR. A minor thing: would mind also updating the portfolio.yml
with an example that shows your changes in action?
@wooshcz I had a wee look already and it looks like three useful improvements. Thanks for the PR. A minor thing: would mind also updating the
portfolio.yml
with an example that shows your changes in action?
Oh not at all! I'm glad you like the changes. I'll update this PR as soon I have some time. Thanks :)
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
Description
Hi!
I've prepared some suggestions for improvements of the portfolio feature:
portfolioitem
links by adding new attributelinktext
which can override the default"Visit Site"
textportfolioitem
only when thelink
attribute is not emptySo far this PR does not contain tests, documentation or an example. Any suggestions are welcome!
Ondrej
Issue Number:
n/a
Additional Information (Optional)
n/a
Checklist
Yes, I included all necessary artefacts, including:
Testing Checklist
Yes, I ensured that all of the following scenarios were tested:
Notify the following users
@lxndrblz