feat: layout improvements for portfolio

wooshcz commented 2 years ago

Description

Hi!

I've prepared some suggestions for improvements of the portfolio feature:

automatic generator of id attributes to enable support for anchor links for portfolio categories
allow for customization of the portfolioitem links by adding new attribute linktext which can override the default "Visit Site" text
generate links for a portfolioitem only when the link attribute is not empty

So far this PR does not contain tests, documentation or an example. Any suggestions are welcome!

Ondrej

Issue Number:

n/a

Additional Information (Optional)

n/a

Checklist

Yes, I included all necessary artefacts, including:

[ ] Tests
[ ] Documentation
[x] Implementation (Code and Ressources)
[x] Example

Testing Checklist

Yes, I ensured that all of the following scenarios were tested:

[x] Desktop Light Mode (Default)
[x] Desktop Dark Mode
[ ] Desktop Light RTL Mode
[ ] Desktop Dark RTL Mode
[x] Mobile Light Mode
[x] Mobile Dark Mode
[ ] Mobile Light RTL Mode
[ ] Mobile Dark RTL Mode

Notify the following users

@lxndrblz

netlify[bot] commented 2 years ago

Deploy Preview for anatole-demo ready!

Name	Link
Latest commit	fea62868f99140b16d9c49f71d5a80ea29bf5afc
Latest deploy log	https://app.netlify.com/sites/anatole-demo/deploys/62403d4ded262600084bfe37
Deploy Preview	https://deploy-preview-334--anatole-demo.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

lxndrblz commented 2 years ago

@wooshcz I had a wee look already and it looks like three useful improvements. Thanks for the PR. A minor thing: would mind also updating the portfolio.yml with an example that shows your changes in action?

wooshcz commented 2 years ago

@wooshcz I had a wee look already and it looks like three useful improvements. Thanks for the PR. A minor thing: would mind also updating the portfolio.yml with an example that shows your changes in action?

Oh not at all! I'm glad you like the changes. I'll update this PR as soon I have some time. Thanks :)