lxndrblz / anatole

Anatole is a minimalistic two-column theme for Hugo.
https://themes.gohugo.io/themes/anatole/
MIT License
651 stars 363 forks source link

fix: apply active class to submenu items #350

Closed guidemetothemoon closed 2 years ago

guidemetothemoon commented 2 years ago

Description

Describe the issue fixed here Recently support for dropdown has been implemented in navigation menu, ref. #344 . There's a small issue there that the menu section will not be underlined as active if any menu options other than the first one will be chosen from the dropdown. So in exampleSite if you had a structure like this:

Accomplishments:
    Awards
    Certifications

Then Accomplishments section will be marked as active only if Awards is an active page but not when Certifications is an active page. This has now been fixed and parent section will be marked as active as long as any of the child sections are currently active.

Issue Number:


Additional Information (Optional)


Checklist

Yes, I included all necessary artefacts, including:


Testing Checklist

Yes, I ensured that all of the following scenarios were tested:


Notify the following users

netlify[bot] commented 2 years ago

Deploy Preview for anatole-demo ready!

Name Link
Latest commit bf76b3f506ff6d057a5995b2bc41200af6d7d21e
Latest deploy log https://app.netlify.com/sites/anatole-demo/deploys/626d05fc2eab48000797394c
Deploy Preview https://deploy-preview-350--anatole-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication