search

lxndrblz / anatole

Anatole is a minimalistic two-column theme for Hugo.
https://themes.gohugo.io/themes/anatole/
MIT License
650 stars 356 forks source link

feat: use custom icon font from icomoon instead of fontawesome #385

Closed Sohn123 closed 1 year ago

Sohn123 commented 1 year ago

Description

Checking the performance via lighthouse revealed, that most of the time loading the website is spent downloading fonts. Most of the icons from fontawesome are currently unused. I created a custom icon font using Icomoon to improve load times. The font is 4.5KB compared to 150KB of fontawesome. Downside is that this would be a breaking change for people using other icons of fontawesome on their website.

Issue Number:

Checklist

Yes, I included all necessary artefacts, including:

Testing Checklist

Yes, I ensured that all of the following scenarios were tested:

netlify[bot] commented 1 year ago

Deploy Preview for anatole-demo failed.

Name Link
Latest commit 4c307ac2e99ff34320cd8a7ba1775f7836c80590
Latest deploy log https://app.netlify.com/sites/anatole-demo/deploys/633b04dc6424a60008715e5a
sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

lxndrblz commented 1 year ago

@Sohn123 Thanks for this PR. I think it certainly shows that there is still huge potential for optimizing load time. Unfortunately, as the theme is aimed at beginners, I am convinced that creating custom icon sets might be a fairly big hurdle for some users. Therefore, I'll close this PR. Thanks for your understanding.

Sohn123 commented 1 year ago

@lxndrblz Ok, I totally understand that. I just want to clarify that for most users, there is no need to create a custom icon font. I think we could agree on a list of supported icons (documented in the wiki), that is far smaller than font-awesome and still supports all necessary icons for this theme. Anybody who wants additional icons can create a custom icon font. But I think additional icons are already an advanced use case :)