Resolve dependency conflict conventional changelog release it

alexanderdavide commented 1 year ago

Description

Installing dependencies, npm errors out due to a peer-dependency issue of @release-it/conventional-changelog v4.2.2 which relied on release-it ^v14.12.1. npm previously reported peer-dependency issues as a warning which changed to being reported as an error in the past months now breaking installs in the workflow.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @release-it/conventional-changelog@4.2.2
npm ERR! Found: release-it@15.4.2
npm ERR! node_modules/release-it
npm ERR!   dev release-it@"^15.4.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer release-it@"^14.12.1" from @release-it/conventional-changelog@4.2.2
npm ERR! node_modules/@release-it/conventional-changelog
npm ERR!   dev @release-it/conventional-changelog@"^4.2.2" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: release-it@14.14.3
npm ERR! node_modules/release-it
npm ERR!   peer release-it@"^14.12.1" from @release-it/conventional-changelog@4.2.2
npm ERR!   node_modules/@release-it/conventional-changelog
npm ERR!     dev @release-it/conventional-changelog@"^4.2.2" from the root project

My proposed solution is to upgrade to @release-it/conventional-changelog v5.1.0. Since v5.1.0 it supports release-it ^v15.3.0 as peer-dependency. Also, the major upgrade to v5.0.0 should be fine as it primarily focused on sunsetting Node.js v12 which reached its end of life already a few months ago. The actual generation of the changelog wasn't affected much.

Additional Information

Additionally, I made sure that

husky is prepared in the "format" workflow.
workflows use stable Node.js versions. v2 of the actions still use Node.js v12. v3 use Node.js 16 by default (actions-cache, actions-checkout, setup-node), however I pinned setup-node to install v14. It is still fine in view of security support and it is the version we're using, at least when we implemented the refactoring and also see the workflow "update resources".

netlify[bot] commented 1 year ago

Deploy Preview for anatole-demo ready!

Name	Link
Latest commit	b5a8cefe6ee4a62cac4136659e2c1fd1aab7e889
Latest deploy log	https://app.netlify.com/sites/anatole-demo/deploys/633b2103808c7a0008f95d92
Deploy Preview	https://deploy-preview-388--anatole-demo.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.