feat: add config option to disable title capitalization

lxndrblz / anatole

Anatole is a minimalistic two-column theme for Hugo.

https://themes.gohugo.io/themes/anatole/

MIT License

657 stars 362 forks source link

feat: add config option to disable title capitalization #408

Closed ericswpark closed 2 months ago

ericswpark commented 1 year ago

Description

Users can set disableTitleCapitalization to true in order to, well, disable title capitalization.

Issue Number

Fixes #368

Additional Information (Optional)

I wrote this on my phone so it may not work?

Checklist

Yes, I included all necessary artefacts, including:

[ ] Tests
[ ] Documentation
[ ] Implementation (Code and Ressources)
[ ] Example

Documentation moved to wiki since I last contributed here, so once this PR is merged I guess the wiki could be edited?

Testing Checklist

Yes, I ensured that all of the following scenarios were tested:

[ ] Desktop Light Mode (Default)
[ ] Desktop Dark Mode
[ ] Desktop Light RTL Mode
[ ] Desktop Dark RTL Mode
[ ] Mobile Light Mode
[ ] Mobile Dark Mode
[ ] Mobile Light RTL Mode
[ ] Mobile Dark RTL Mode

Notify the following users

@McPringle
@lxndrblz

netlify[bot] commented 1 year ago

Deploy Preview for anatole-demo processing.

Name	Link
Latest commit	a5229f86d76d7a160164be9f40768a30021e11c0
Latest deploy log	https://app.netlify.com/sites/anatole-demo/deploys/66a12f58a227aa00081dd929

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

lxndrblz commented 1 year ago

@ericswpark Thanks for your PR. I wonder if that's really sufficient Shouldn't the capitalization also be disabled on the portfolio page and in the post series snippet?

ericswpark commented 1 year ago

@lxndrblz it really is a rough draft I wrote on my phone so I may have (read: probably will have) missed a ton.

In addition this PR doesn't affect any CSS rules, as noted in the original issue report. I opted not to include it because a) I don't know how to disable CSS rules based on Hugo configuration, and b) we still need to figure out whether to have it configurable in one configuration option or in a separate one.

sonarcloud[bot] commented 2 months ago