lxndrblz / anatole

Anatole is a minimalistic two-column theme for Hugo.
https://themes.gohugo.io/themes/anatole/
MIT License
650 stars 356 forks source link

General styling for tables - Add _table.scss to /assets/scss/partials/vendor #424

Closed JohnMThompson closed 1 year ago

JohnMThompson commented 1 year ago

Description

Add simple CSS style for tables.

Issue Number:


Additional Information (Optional)

Added two changes, a _table.scss to the vendor folder and a corresponding entry in the main.scss file. This is an extremely simple table css style to help render in markdown tables

Before addition tables rendered like this: image

After adding css, tables render like this: image


Checklist

Yes, I included all necessary artefacts, including:


Testing Checklist

Yes, I ensured that all of the following scenarios were tested:


Notify the following users

netlify[bot] commented 1 year ago

Deploy Preview for anatole-demo ready!

Name Link
Latest commit 38de0c9dfe6bb598bef0effb980bd001553ef59c
Latest deploy log https://app.netlify.com/sites/anatole-demo/deploys/6439d2fa8d12c10008861389
Deploy Preview https://deploy-preview-424--anatole-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

belidzs commented 1 year ago

I've tried this as a custom CSS, but doesn't look great in dark mode (outline is black on grey)

JohnMThompson commented 1 year ago

I've tried this as a custom CSS, but doesn't look great in dark mode (outline is black on grey)

Thanks for the feedback, I'll take a look at it this week!

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information