search

lxndrblz / anatole

Anatole is a minimalistic two-column theme for Hugo.
https://themes.gohugo.io/themes/anatole/
MIT License
661 stars 364 forks source link

Implement multilingual portfolio data #481

Closed sebastianlacuesta closed 4 months ago

sebastianlacuesta commented 1 year ago

Description

This pull request implements multilingual support for portfolio data. Data for portfolio is looked at data/<language-code>/portfolio.yml first and if it doesn't exists, then we use data/portfolio.yml like before.

Issue Number:

397

Checklist

Yes, I included all necessary artefacts, including:

I can add a spanish translation of the exampleSite and provide a working example if you want.

Testing Checklist

Yes, I ensured that all of the following scenarios were tested:

There's no porfolio example for RTL mode and I don't know how to test it.

Notify the following users

netlify[bot] commented 1 year ago

Deploy Preview for anatole-demo failed.

Name Link
Latest commit f2f5138abe12e34a2243d027d9ac54c6216fa637
Latest deploy log https://app.netlify.com/sites/anatole-demo/deploys/65694f586145e6000801b47e
sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sebastianlacuesta commented 1 year ago

I can´t reproduce the first error on my setup. No errors for me.

$ cd exampleSite && hugo --gc --minify --themesDir ../..
WARN  deprecated: config: languages.ar.description: custom params on the language top level was deprecated in Hugo v0.112.0 and will be removed in a future release. Put the value below [languages.ar.params]. See https://gohugo.io/content-management/multilingual/#changes-in-hugo-01120
Start building sites … 
hugo v0.120.3+extended linux/amd64 BuildDate=2023-11-07T23:07:34Z VendorInfo=debian:0.120.3-1

WARN  The "twitter_simple" shortcode will soon require two named parameters: user and id. See "/home/sebastian/go/src/github.com/sebastianlacuesta/anatole/exampleSite/content/english/post/rich-content.md:26:1"
WARN  _internal/google_analytics_async.html is no longer supported by Google and will be removed in a future version of Hugo

                   | EN | AR  
-------------------+----+-----
  Pages            | 65 | 19  
  Paginator pages  |  1 |  0  
  Non-page files   |  0 |  0  
  Static files     | 11 | 11  
  Processed images |  0 |  0  
  Aliases          | 13 |  9  
  Sitemaps         |  2 |  1  
  Cleaned          |  4 |  4  

Total in 189 ms