Closed gfgit closed 7 months ago
Glad to see that you've participated in the Qt6 port.
Nice! Maybe you've seen already https://github.com/orgs/lxqt/projects/3/views/1
For testing purpose I've a KDE Neon developer edition in Vbox:
find_package(PolkitQt6-1 REQUIRED) # TODO: does not seem to be available yet
Nice! I didn't notice. Now I've setup a GNOME Boxes VM with Neon Unstable which is a bit faster than VirtualBox. Also there is X11 specific code about XScreenSaver and lock screen in general which I don't know how to port to Wayland. For now they are just skipped and a warning is emitted. Are there any compositor-agnostic Wayland protocols about lockscreen?
which I don't know how to port to Wayland.
Please don't include porting to Wayland in this PR, which is for porting to Qt6.
I forgot to mention that this Vbox with Neon already blocked twice here, just editing files.
Are there any compositor-agnostic Wayland protocols about lockscreen?
For the future: https://wayland.app/protocols/ext-session-lock-v1
which I don't know how to port to Wayland.
Please don't include porting to Wayland in this PR, which is for porting to Qt6.
Yes of course, but at least a warning line so it's easier to find for later wayland port?
at least a warning line so it's easier to find for later wayland port?
Right. My comment was just a general remark :) Otherwise, your work has always been clean.
Managed to compile it on Neon, after 2 blocks:
libkf6windowsystem-dev
and related are something like v5.245scrnsaver.h
Managed to compile it on Neon, after 2 blocks:
* set(KF5_MINIMUM_VERSION "6.0.0") for some reason on Neon the package` libkf6windowsystem-dev` and related are something like v5.245 * Cmake doesn't check for libxss-dev so if it's not installed it stops at 82% with error about missing `scrnsaver.h`
Can we do something about this or is it just a Neon bug?
I've no idea if they will update to 6.* the package versions at release, just changed the version to 5.2 in CMakeList.txt
.
Compiling I get
-- Looking for IceConnectionNumber in ICE - found
CMake Error at /usr/local/share/cmake/lxqt2/lxqt2-config.cmake:59 (include):
include could not find requested file:
/usr/local/share/cmake/lxqt2/lxqt-targets.cmake
Call Stack (most recent call first):
CMakeLists.txt:25 (find_package)
Changing to "lxqt2" at the end of lxqt-config.cmake.in
solves:
include("${CMAKE_CURRENT_LIST_DIR}/lxqt2-targets.cmake")
But both apps I try (globalkeys and lxqt-about) don't find #include QDialog
or QObject
at some point.
Changing to "lxqt2" at the end of
lxqt-config.cmake.in
solves:
Fixed with latest commit.
But both apps I try (globalkeys and lxqt-about) don't find
#include QDialog
orQObject
at some point.
I get this error too but only some files of global-keys
CMake project seems affected. Also auto completion and syntax highlighting in Qt Creator work only on some files which means it cannot parse include directives, in fact compilation fails in same places.
More precisely I can build lxqt-globalkeys
CMake target but not all
target because it fails to build lxqt-globalkeysd
Actually the same here too: translations aren't build without changing prefix to *.ts
files. I made a test with resetting all to "lxqt" everywhere and translations get installed and my strange errors about "QDialog not found" and else where gone too.
Just drop this: there is no check forlibxss-dev
(package name in Neon), so compilation fails at 70%.
What's the error?
I took a quick look at the changes, and they seemed all good. Also, the code was compiled without problem under Manjaro Testing (+ KF6). Will read it again soon. Thanks!
Depends on lxqt-build-tools#77