search

lxqt / libqtxdg

Qt implementation of freedesktop.org xdg specs
https://lxqt.github.io
GNU Lesser General Public License v2.1
73 stars 35 forks source link

Loop executed once #172

Closed shlyakpavel closed 5 years ago

shlyakpavel commented 5 years ago

There is an unconditional 'break' within a loop. This is really suspicious :) https://github.com/lxqt/libqtxdg/blob/1a52e5cb5203a51c1a450bb7fd7268e22fc7c03b/src/xdgiconloader/xdgiconloader.cpp#L474 Have a nice day!

shlyakpavel commented 5 years ago

Probably intentional. Caused by https://github.com/lxqt/libqtxdg/pull/116 However, I would prefer it to be an if condition instead

tsujan commented 5 years ago

Yes, it's very suspicious. A typo?

tsujan commented 5 years ago

I would prefer it to be an if condition instead

Again, yes! It should be if. The while loop is a remnant of the previous code.