search

lxqt / libqtxdg

Qt implementation of freedesktop.org xdg specs
https://lxqt.github.io
GNU Lesser General Public License v2.1
73 stars 35 forks source link

Modernize #183

Closed luis-pereira closed 5 years ago

luis-pereira commented 5 years ago

Use C++11 features. Done with clang-tidy.

tsujan commented 5 years ago

Nice!

(1) Raw string literals have problem with translation updates with Qt < 5.12.2 (I think @palinek fixed them in Qt). Do we require that version? (2) Now that the code is updated, why not replacing QRegExp with QRegularExpression too?

palinek commented 5 years ago

(1) Raw string literals have problem with translation updates with Qt < 5.12.2 (I think @palinek fixed them in Qt). Do we require that version?

It seems, it is backported into versions from 5.12 -> https://github.com/qt/qttools/commit/ee9f6ec9b9e8f0d18ad7e8fededb5292abb91912

luis-pereira commented 5 years ago

Nice!

(1) Raw string literals have problem with translation updates with Qt < 5.12.2 (I think @palinek fixed them in Qt). Do we require that version?

Wasn't aware of that. Tested it and it passed, assumed it was good to go with other versions.

(2) Now that the code is updated, why not replacing QRegExp with QRegularExpression too?

Sure. In another pass.

tsujan commented 5 years ago

It seems, it is backported into versions from 5.12

I recompiled it with your patch since Qt 5.11 (needed it for my apps) but, only when 5.12.2 was released, I didn't need a recompilation.

Anyhow, it'll be OK if there's nothing to translate in files with raw string literals.

luis-pereira commented 5 years ago

Anyhow, it'll be OK if there's nothing to translate in files with raw string literals.

That's the case.

tsujan commented 5 years ago

That's the case.

Good.